Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(dependabot): remove reviewers config #121

Merged
merged 1 commit into from
Oct 25, 2023
Merged

ci(dependabot): remove reviewers config #121

merged 1 commit into from
Oct 25, 2023

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Oct 25, 2023 •
edited
Loading

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #118

Description of the change:

Dependabot should not be requesting review from both maintainers and reviewers teams. With this change only maintainers should be requested

Motivation for the change:

Bug reported by @andrewazores: Dependabot PRs end up requesting review from both maintainers and reviewers teams.

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@aali309 aali309 marked this pull request as ready for review October 25, 2023 18:07
@andrewazores andrewazores added ci and removed fix labels Oct 25, 2023
@andrewazores andrewazores changed the title fix(ci): removed reviewers from dependabot ci(dependabot): remove reviewers config Oct 25, 2023
@andrewazores andrewazores merged commit 258c103 into cryostatio:main Oct 25, 2023
25 of 32 checks passed
@aali309 aali309 deleted the fixDependabot branch October 25, 2023 18:18
@tthvo tthvo mentioned this pull request Oct 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
ci safe-to-test
Projects
No open projects
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Dependabot PRs request review from both maintainers and reviewers
2 participants
@aali309 @andrewazores