Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(scripts): add scripts to ease local chart testing #196

Merged
merged 11 commits into from
Sep 17, 2024

Conversation

andrewazores
Copy link
Member

  • test(ct): add utility script for running ct locally
  • add script for running connection tests

Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to convert these into a Makefile?

@andrewazores
Copy link
Member Author

I could, but I think it would mostly end up being just inline shell commands anyway, so I don't know how much that would really gain.

@tthvo
Copy link
Member

tthvo commented Sep 9, 2024

I could, but I think it would mostly end up being just inline shell commands anyway, so I don't know how much that would really gain.

Ah okayy! I was just thinking Makefile could define some targets that install the chart for some scenarios (i.e. port-forward, with route, with ingress, etc) to help with testing.

@andrewazores
Copy link
Member Author

It could, but unless there is a particular reason to use a Makefile, I'd rather not :-) if it adds something useful on top of bash scripts then yes, or else if it's also going to provide conventional make clean install kind of commands for users/developers. But if it's only for running different test scenarios then that sounds no better (and IMO, worse) than just having some bash scripts.

@tthvo
Copy link
Member

tthvo commented Sep 9, 2024

It could, but unless there is a particular reason to use a Makefile, I'd rather not :-) if it adds something useful on top of bash scripts then yes, or else if it's also going to provide conventional make clean install kind of commands for users/developers. But if it's only for running different test scenarios then that sounds no better (and IMO, worse) than just having some bash scripts.

Oh alright! I got no specific reasons to use Makefile (just very used to have them around^^). Otherwise, bash scripts sound good to me :D

ct.bash Outdated Show resolved Hide resolved
ct.bash Show resolved Hide resolved
k8s-test.bash Outdated Show resolved Hide resolved
k8s-test.bash Outdated Show resolved Hide resolved
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good^^

@andrewazores andrewazores merged commit 326bc39 into cryostatio:main Sep 17, 2024
6 checks passed
@andrewazores andrewazores deleted the chart-test-script branch September 17, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants