Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployments): separate db, storage, and reports deployments #192

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

andrewazores
Copy link
Member

Fixes #114 #185 #188

Includes #184 #189 #191

@andrewazores andrewazores added feat New feature or request safe-to-test breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere labels Sep 6, 2024
@tthvo
Copy link
Member

tthvo commented Sep 20, 2024

The helm test fail seems related to a timeout waiting for Cryostat main pod to be healthy (i.e. the old set up with 6 containers). Maybe, increase the timeout could help with this test flankiness?

helm-extra-args: --timeout=600s

@andrewazores
Copy link
Member Author

andrewazores commented Sep 23, 2024

I think that's already quite a long timeout - it shouldn't take 10 minutes for things to get ready. Maybe if the network connection for the test runner is slow and it takes a long time to pull the container images, but even then, 10 minutes still seems like a lot.

I say we get #197 integrated and see if that doesn't fix the test reliability. If things are still timing out and we cannot find any other culprit then maybe increasing the timeout is the last resort.

@tthvo
Copy link
Member

tthvo commented Sep 23, 2024

I think CI needs updating to add --force option to helm or we must wait for #200 .

@tthvo
Copy link
Member

tthvo commented Sep 24, 2024

I think CI needs updating to add --force option to helm or we must wait for #200 .

Sorry, as per comment #201 (comment), this is not right behaviour of --force in v3. I think we do need to rename the deployment for seamless upgrade (i.e. CI tests this)...

@andrewazores andrewazores marked this pull request as ready for review September 27, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere feat New feature or request safe-to-test
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

[Task] Deploy oauth2-proxy in front of Cryostat, storage, db, jfr-datasource, and Grafana
2 participants