Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): reorganize workflows and add jobs to check readme diff #179

Merged
merged 12 commits into from
Jul 18, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Jul 18, 2024

Related to #73

Descriptions

Chore

  • Split Chart Lint and Test into separate workflow.
  • Rename workflows to be consistent.
  • Cleaned up README Installation section to be a bit nicer.

Feature

  • Added a job to check if README requires updating.

Motivations

Currently, developers have to remember regenerating README + using the correct readme-generator tool and version. This new workflow can serve as a reminder and suggest hints on which command to run to update README.

Others

The latest version of readme-generator (2.6.1) has some breaking changes, I believe. So, I am keeping it as 2.5.x.

Samples

@tthvo tthvo added feat New feature or request chore Refactor, rename, cleanup, etc. docs ci safe-to-test labels Jul 18, 2024
@tthvo tthvo requested a review from a team July 18, 2024 01:59
@andrewazores andrewazores merged commit 7afb089 into cryostatio:main Jul 18, 2024
6 checks passed
@tthvo tthvo deleted the readme-diff-ci branch July 18, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. ci docs feat New feature or request safe-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants