revert: echo should only used when necessary

cryostatio · Jul 18, 2024 · 45fb9cf · 45fb9cf
1 parent 833dd5d
commit 45fb9cf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/charts/cryostat/templates/NOTES.txt b/charts/cryostat/templates/NOTES.txt
@@ -52,14 +52,14 @@
 {{- else if .Values.core.ingress.enabled }}
 {{- range $host := .Values.core.ingress.hosts -}}
  {{- range .paths }}
- echo {{ ternary "http" "https" (empty $.Values.core.ingress.tls) }}://{{ $host.host }}{{ .path }}
+ {{ ternary "http" "https" (empty $.Values.core.ingress.tls) }}://{{ $host.host }}{{ .path }}
  {{- end }}
 {{- end }}
 {{- else if contains "NodePort" .Values.core.service.type }}
  echo http://$NODE_IP:$NODE_PORT
 {{- else if contains "LoadBalancer" .Values.core.service.type }}
  echo http://$SERVICE_IP:{{ .Values.core.service.httpPort }}
 {{- else if contains "ClusterIP" .Values.core.service.type }}
- echo http://localhost:8080
+ http://localhost:8080
 {{- end }}
  ```
diff --git a/charts/cryostat/tests/notes_test.yaml b/charts/cryostat/tests/notes_test.yaml
@@ -25,7 +25,7 @@ tests:
 
  1. Visit the application at:
  ```
- echo https://example.com/
+ https://example.com/
  ```
 
  - it: should render correct notes for enabled route without TLS
@@ -63,7 +63,7 @@ tests:
  ```
  echo https://$(oc get route -n NAMESPACE RELEASE-NAME-cryostat -o jsonpath="{.status.ingress[0].host}")
  ```
- 
+
  - it: should render correct notes for NodePort service without ingress or route
  set:
  core.service.type: "NodePort"
@@ -128,5 +128,5 @@ tests:
 
  3. Visit the application at:
  ```
- echo http://localhost:8080
+ http://localhost:8080
  ```