Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added kitops in list.md #956

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

Astrodevil
Copy link
Contributor

Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:

fixes #955 (Add KitOps to Hacktoberfest Swag List)

  1. I have read the Contributing.md file and formatted this PR correctly
  2. I'm not adding a company from the blocklist
  3. I make sure to fix things promptly if an error or suggestion comes up

Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀

docs/list.md Outdated
- Make successful contributions on issues tagged with `hacktoberfest` to win a KitOps branded T-shirt
- **How to sign up**: No signup needed, KitOps team will be raffling off swag to community members who contribute to project all month.
- **Issues**: Issues [tagged with hacktoberfest](https://github.com/jozu-ai/kitops/issues?q=is%3Aissue+is%3Aopen+label%3Ahacktoberfest) label.
- **Notes**: Visit [KitOps Anoouncement Post](https://x.com/Kit_Ops/status/1844426229266653412)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for hacktoberfest-swag-list ready!

Name Link
🔨 Latest commit 3935de7
🔍 Latest deploy log https://app.netlify.com/sites/hacktoberfest-swag-list/deploys/67231df5b3bf090009aeba76
😎 Deploy Preview https://deploy-preview-956--hacktoberfest-swag-list.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/list.md Outdated Show resolved Hide resolved
Copy link
Contributor

@vimode vimode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Astrodevil, Thank you for contributing! 🥳
I've made some suggestions to your PR. But the major change thats needed is, to move this in alphabetical order. And please do fix the code climate formatting errors after.

Thank you.

Co-authored-by: vimode <[email protected]>
docs/list.md Outdated
- KitOps team will be raffling off swag to community members who contribute to project all month.
- **How to sign up**: No signup needed,
- **Issues**: Issues [tagged with hacktoberfest](https://github.com/jozu-ai/kitops/issues?q=is%3Aissue+is%3Aopen+label%3Ahacktoberfest) label.
- **Notes**: Check the [KitOps announcement on X](https://x.com/Kit_Ops/status/1844426229266653412) for more details.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing punctuation in header

docs/list.md Outdated
- KitOps team will be raffling off swag to community members who contribute to project all month.
- **How to sign up**: No signup needed,
- **Issues**: Issues [tagged with hacktoberfest](https://github.com/jozu-ai/kitops/issues?q=is%3Aissue+is%3Aopen+label%3Ahacktoberfest) label.
- **Notes**: Check the [KitOps announcement on X](https://x.com/Kit_Ops/status/1844426229266653412) for more details.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

Copy link

codeclimate bot commented Oct 31, 2024

Code Climate has analyzed commit 3935de7 and detected 0 issues on this pull request.

View more on Code Climate.

@crweiner
Copy link
Owner

Thank you for your PR, @Astrodevil, and for @vimode for your review! I've made some changes that @vimode suggested, given the time period in getting this on the swag list.

Thanks again all!

@crweiner crweiner merged commit 5d935ad into crweiner:master Oct 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add KitOps to Hacktoberfest Swag List
3 participants