Build goes green #18
Merged
Build goes green #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5.5 and add types Refactor `abstract-chart.ts` to use direct imports from apache-echarts 5.5 and add TypeScript types. * **Imports** - Replace `import * as echarts from 'echarts'` with direct imports from `echarts/core`, `echarts/renderers`, `echarts/components`, and `echarts/charts`. - Add `use` function to register necessary components and charts. * **TypeScript Types** - Add TypeScript types for `ChartArgs`, `Context`, `Layout`, `Style`, `BoxConfig`, `TitleConfig`, `LegendConfig`, `DataZoomConfig`, `TextConfig`, `GraphicElement`, `GraphicConfig`, `EChartsConfig`, `EChartsOptionWithGraphic`, `EChartsOptionWithTitle`, `EChartsOptionWithLegend`, `EChartsOptionWithDataZoom`, `EChartsOptionWithTooltip`, `EChartsOptionWithGrid`, `EChartsOptionWithSeries`, and `EChartsOptionWithAll`. - Update method signatures to include TypeScript types. - Add optional chaining and type assertions where necessary. * **Methods** - Update `createChart` method to use `init` from `echarts/core`. - Update `configureChart`, `buildLayout`, `addChartBox`, `addTitle`, `addLegend`, `addDataZoom`, `addCellBoxes`, `addCellTitles`, `addCellPlots`, `addCellTextOverlays`, `getLegendLabels`, `getLegendOrientation`, `generateBoxConfig`, `generateTitleConfig`, `generateLegendConfig`, `generateXAxisDataZoomConfig`, `generateYAxisDataZoomConfig`, `generateDataZoomConfigElement`, `generateTextConfig`, and `computeLegendMetrics` methods to use the new types and direct imports. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/crunchybananas/ember-apache-echarts?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request involves several changes aimed at improving type safety and code clarity in the
ember-apache-echarts/src/modifiers/bar-chart.tsfile. The main changes include adding clarifying comments to@ts-expect-errorannotations and refining imports to optimize bundle size.Type Safety and Code Clarity Improvements:
@ts-expect-errorannotations to indicate that follow-up is needed. (ember-apache-echarts/src/modifiers/bar-chart.ts) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26]Import Optimization:
echarts/core. (ember-apache-echarts/src/modifiers/bar-chart.ts)