Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filament v3 Support #19

Merged
merged 16 commits into from
Sep 13, 2023
Merged

Filament v3 Support #19

merged 16 commits into from
Sep 13, 2023

Conversation

Log1x
Copy link
Contributor

@Log1x Log1x commented Aug 9, 2023

This adds Filament v3 support as well as a plugin class to register the plugin to the panel with configuration.

return $panel
    ->plugins([
        \Croustibat\FilamentJobsMonitor\FilamentJobsMonitorPlugin::make()
            ->label('Job')
            ->pluralLabel('Jobs')
            ->enableNavigation(true)
            ->navigationIcon('heroicon-o-cpu-chip')
            ->navigationGroup('Settings')
            ->navigationSort(5)
            ->navigationCountBadge(true)
            ->enablePruning(true)
            ->pruningRetention(7)
            ->resource(\App\Filament\Resources\CustomJobMonitorResource::class)
    ]);

Todo

Change log

  • ✨ Add support for Filament v3
  • 🔧 Implement a configurable panel plugin class
  • 🔧 Make table columns sortable (Supersedes Update QueueMonitorResource to Fix and apply sorting #15)
  • 🔧 Add a configurable navigation menu resource sort order (Supersedes Changed QueueMonitorResource #18)
  • 🔧 Add a toggle to show a job count badge in the navigation menu
  • 🔧 Add a configuration option to customize the QueueMonitorResource model
  • 🔧 Split the resource label into singular and plural
  • 🔧 Update plugin config to reflect v3 changes
  • 🔧 Make the ListQueueMonitors methods public to coincide with Filament v3
  • 🚨 Run Pint

@Log1x
Copy link
Contributor Author

Log1x commented Aug 9, 2023

Waiting on ryangjchandler/filament-progress-column#20 – otherwise this is ready to roll.

Screenshot

@croustibat
Copy link
Owner

Great ! Thank you for this contribution !!
I need to try Filament v3 first, then i'll merge it ;)

@Log1x
Copy link
Contributor Author

Log1x commented Aug 9, 2023

Great ! Thank you for this contribution !! I need to try Filament v3 first, then i'll merge it ;)

No problem. Still waiting on the progress bar update to get merged but we could always put a temporary TextColumn in its place so a release can get pushed. It's just commented out right now.

Also sorry if some of the changes (mainly to the config) are a bit opinionated. They just made sense with how plugins are registered to the panel now. Feel free to change them.

@Log1x
Copy link
Contributor Author

Log1x commented Aug 9, 2023

Went ahead and added the TextColumn for now.

Screenshot

@iRajul
Copy link

iRajul commented Aug 11, 2023

Could you please make a new release with v3 support. Thanks for great plugin.

@croustibat
Copy link
Owner

Hey @Log1x Sorry for the long silence. i'm currently working on your PR, validating it inside a filament V3 local app.
Release really soon !

@croustibat croustibat self-requested a review September 13, 2023 16:14
@croustibat croustibat merged commit 505070f into croustibat:main Sep 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants