Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Commit

Permalink
[cca]Add the [email protected] for cca
Browse files Browse the repository at this point in the history
Add cordova-android 6.0.0 explicitly for cca build.

Impacted tests(approved): new 0, update 2, delete 0
Unit test platform: Crosswalk Project for Android 23.53.589.0
Unit test result summary: pass 2, fail 0, block 0

BUG=https://crosswalk-project.org/jira/browse/CTS-1916
  • Loading branch information
qiuzhong committed Nov 7, 2016
1 parent b609081 commit e45b94c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions cordova/cordova-sampleapp-android-tests/sampleapp/comm.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def create(appname, pkgname, mode, sourcecodepath, replace_index_list, self, ext
do_remove(glob.glob(os.path.join(project_root, "www")))
do_copy(sourcecodepath, os.path.join(tool_path, appname, "www"))

def buildGoogleApp(appname, sourcecodepath, self):
def buildGoogleApp(appname, sourcecodepath, self, cordova_android_ver = "6.0.0"):
os.chdir(tool_path)
if os.path.exists(os.path.join(tool_path, appname)):
print "Existing %s project, try to clean up..." % appname
Expand Down Expand Up @@ -209,7 +209,7 @@ def buildGoogleApp(appname, sourcecodepath, self):
os.chdir(os.path.join(tool_path, appname))

print "Add android platforms to this project --------------> START"
add_android_cmd = "cca platform add android"
add_android_cmd = "cca platform add android@%s" % cordova_android_ver
addstatus = commands.getstatusoutput(add_android_cmd)
self.assertEquals(0, addstatus[0])

Expand Down
4 changes: 2 additions & 2 deletions tools/build/pack_cordova_sample.py
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ def copyCordovaCliApk(app_name, orig_dir, apk_name_arch="armv7", apk_name_mode="

return True

def packGoogleApp(app_name=None):
def packGoogleApp(app_name=None, cordova_android_ver = "6.0.0"):
project_root = os.path.join(BUILD_ROOT, app_name)
orig_dir = os.getcwd()
buildstatus = commands.getstatusoutput("cca -v")
Expand Down Expand Up @@ -530,7 +530,7 @@ def packGoogleApp(app_name=None):
'</widget>',
' <allow-navigation href="*" />\n</widget>')

add_cmd = "cca platform add android"
add_cmd = "cca platform add android@%s" % cordova_android_ver
if not doCMD(add_cmd, DEFAULT_CMD_TIMEOUT * 2):
os.chdir(orig_dir)
return False
Expand Down

0 comments on commit e45b94c

Please sign in to comment.