Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume DesiredStateChanged predicate #179

Closed
wants to merge 3 commits into from
Closed

Consume DesiredStateChanged predicate #179

wants to merge 3 commits into from

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Mar 24, 2023

Description of your changes

This PR:

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Create an s3 bucket and try deleting it when empty and non-empty.

@turkenh
Copy link
Member Author

turkenh commented Mar 24, 2023

During implementation, I realized that the current async operation callback mechanism does not backoff with failures and this PR will only keep it working as before rather than fixing it, I opened a separate issue for that: #180

@ulucinar
Copy link
Collaborator

We had sync'ed with @turkenh about this PR and had agreed to consume the predicates as event filters in #231 on top of the reconcile request requeue mechanism we had introduced. Closing this PR...

@ulucinar ulucinar closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants