Skip to content

Commit

Permalink
update toolchain and move disconnect method
Browse files Browse the repository at this point in the history
Signed-off-by: smcavallo <[email protected]>
  • Loading branch information
smcavallo committed Sep 11, 2024
1 parent 865f06f commit 79d90ed
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
2 changes: 0 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ module github.com/crossplane/upjet

go 1.22.7

toolchain go1.23.1

require (
dario.cat/mergo v1.0.0
github.com/alecthomas/kingpin/v2 v2.4.0
Expand Down
8 changes: 4 additions & 4 deletions pkg/controller/external.go
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,6 @@ type external struct {
logger logging.Logger
}

func (e *external) Disconnect(ctx context.Context) error {
return nil
}

func (e *external) scheduleProvider(name string) (bool, error) {
if e.providerScheduler == nil || e.workspace == nil {
return false, nil
Expand Down Expand Up @@ -432,6 +428,10 @@ func (e *external) Delete(ctx context.Context, mg xpresource.Managed) (managed.E
return managed.ExternalDelete{}, errors.Wrap(e.workspace.Destroy(ctx), errDestroy)
}

func (e *external) Disconnect(_ context.Context) error {
return nil
}

func (e *external) Import(ctx context.Context, tr resource.Terraformed) (managed.ExternalObservation, error) {
res, err := e.workspace.Import(ctx, tr)
if err != nil {
Expand Down

0 comments on commit 79d90ed

Please sign in to comment.