Improve Docs Typography and Improve/Fix Accordion Styling #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shanecmiller23
force-pushed
the
master
branch
2 times, most recently
from
38bd6a1
to
ad02f77
Compare
jbw976
reviewed
Aug 4, 2023
There was a problem hiding this comment.
@shanecmiller23 can you add some content to the PR description/body that summarizes that has changed in this PR and what reviewers should be looking for in the code and deploy preview site? for example:
- i see a bunch of new snippets, but nothing referring to them - how are those intended to be used?
- what's an accordion? where can i see an example of that element on the current site?
|
@jbw976 I updated the description outlining the changes! Apologies, still working on my GitHub etiquette/processes 👍 I do not know what the snippets are. @plumbis said it's from a git problem. I picked up some commits that should have been in master. He'll take a look in the morning but said it shouldn't be much of an issue |
shanecmiller23
force-pushed
the
master
branch
4 times, most recently
from
70fe08b
to
d6b06b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typography updates:
Accordion updates:
(example can be found under "hide long outputs" here: https://64cc77cec73a020008929f21--crossplane.netlify.app/contribute/features/)