feat(xfn): add v1beta1 interface #511
Conversation
Signed-off-by: Philippe Scorsolini <[email protected]>
| limitations under the License. | ||
| */ | ||
|
|
||
| syntax = "proto3"; |
There was a problem hiding this comment.
Can we setup linting and code generation here, similar to what we have in c/c?
https://github.com/crossplane/crossplane/blob/59b2e12f/apis/generate.go#L81
Linting via buf lint would be nice too, but we can add that later.
There was a problem hiding this comment.
We do have code generation already in place here, and I used make generate to generate the code from the .proto file directly. I can add linting though!
There was a problem hiding this comment.
Ah I see that's a to do in crossplane too, I'll see if I can find my way through the build submodule 😆
| // - protoc (unknown) | ||
| // source: proto/v1beta1/fn/run_function.proto | ||
|
|
||
| package v1beta1 |
There was a problem hiding this comment.
I wonder whether this belongs here, or in a crossplane/function-runtime-go repo?
I would expect the generated Python code to live in crossplane/function-runtime-python for example. Go is a bit of a special case because the generated code will be used by c/c and c/function-runtime-oci as well as any Function written in Go.
I guess alternatively we could just keep all the function runtimes/SDKs in this repo to start with. 🤔
There was a problem hiding this comment.
crossplane-runtime is already go specific, so we could think of keeping it here forever. I agree we could think of having a dedicated repository for each sdk, but I'd start simple and reconsider the choice once we'll start having more sdks. WDYT?
|
Closed as we decided to move the generated code to a dedicated repository to avoid having to import xp-runtime from functions. |
Description of your changes
Move v1beta1 rpc interface introduced in crossplane/crossplane#4431 from crossplane to here.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested