Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Terraform Plugin SDK to Reconcile MRs #424

Merged
merged 20 commits into from
Dec 13, 2023
Merged

Use Terraform Plugin SDK to Reconcile MRs #424

merged 20 commits into from
Dec 13, 2023

Conversation

ulucinar
Copy link
Collaborator

Description of your changes

This PR employs the controller.noForkExternal & controller.noForkAsyncExternal external clients from upjet to reconcile MRs without forking any Terraform CLI or Terraform provider processes.

Some more details on these clients can be found here.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@ulucinar ulucinar marked this pull request as draft November 17, 2023 12:33
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/cloudplatform/serviceaccount.yaml"

1 similar comment
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/cloudplatform/serviceaccount.yaml"

@ulucinar ulucinar mentioned this pull request Nov 20, 2023
Merged
1 task
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/cloudplatform/serviceaccount.yaml"

@ulucinar
Copy link
Collaborator Author

/test-examples="examples/cloudplatform/serviceaccount.yaml"

@ulucinar
Copy link
Collaborator Author

There's a successful platform-ref-gcp uptest run here using the index.docker.io/ulucinar/provider-gcp-{cloudplatform,compute,container,servicenetworking,sql}:v0.39.0-5848867bfc17168b008f3a6c5bc24541baef0fb0 packages built at this point.

@erhancagirici
Copy link
Collaborator

/test-examples="examples/storage/bucket.yaml"

1 similar comment
@erhancagirici
Copy link
Collaborator

/test-examples="examples/storage/bucket.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/cloudplatform/serviceaccount.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/storage/bucket.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/redis/instance.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/pubsub/litereservation.yaml,examples/pubsub/litesubscription.yaml,examples/pubsub/litetopic.yaml,examples/pubsub/schema.yaml,examples/pubsub/subscriptioniammember.yaml,examples/pubsub/topiciammember.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/monitoring/"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/logging/"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/servicenetworking/connection.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/notebooks/"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/artifact/"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/gkehub/"

@jeanduplessis jeanduplessis mentioned this pull request Nov 30, 2023
Closed
@erhancagirici
Copy link
Collaborator

/test-examples="examples/cloudrun/v2job.yaml,examples/cloudrun/v2service.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/servicenetworking/connection.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/kms/cryptokeyiammember.yaml,examples/kms/secretciphertext.yaml,examples/kms/keyringiammember.yaml,examples/kms/keyringimportjob.yaml,examples/gkehub/membershipiammember.yaml,examples/gkehub/membership.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/artifact/registryrepository.yaml,examples/secretmanager/secret.yaml,examples/secretmanager/secretiammember.yaml,examples/secretmanager/secretversion.yaml,examples/cloudrun/v2job.yaml,examples/cloudrun/v2service.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/artifact/registryrepository.yaml,examples/secretmanager/secret.yaml,examples/secretmanager/secretiammember.yaml,examples/secretmanager/secretversion.yaml"

@erhancagirici
Copy link
Collaborator

/test-examples="examples/monitoring/alertpolicy.yaml,examples/monitoring/customservice.yaml,examples/monitoring/dashboard.yaml,examples/monitoring/group.yaml,examples/monitoring/metricdescriptor.yaml,examples/monitoring/notificationchannel.yaml,examples/monitoring/service.yaml,examples/monitoring/slo.yaml,examples/monitoring/uptimecheckconfig.yaml"

@sergenyalcin
Copy link
Collaborator

/test-examples="examples/compute/instancefromtemplate.yaml"

@sergenyalcin
Copy link
Collaborator

/test-examples="examples/compute/instancetemplate.yaml"

@ulucinar ulucinar marked this pull request as ready for review December 13, 2023 08:15
ulucinar and others added 20 commits December 13, 2023 11:22
@ulucinar
Switch to the no-fork architecture for the Google resources
3874bf2 
- Bump upjet to v1.0.0
- Bump Go version to 1.21

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@erhancagirici @ulucinar
update build submodule to handle family providers
4f8338d 
Signed-off-by: Erhan Cagirici <[email protected]>
@ulucinar
Bump the Go version in go.mod to 1.21
17653b8 
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@sergenyalcin @ulucinar
Bumg upjet dependency to the a9788207cd72acf7743805fa637c5a775607ebf2…
06f2ab5 
… commit

Signed-off-by: Sergen Yalçın <[email protected]>
@sergenyalcin @ulucinar
Generate server-side apply markers
45f360c 
Signed-off-by: Sergen Yalçın <[email protected]>
@erhancagirici @ulucinar
fix Cluster/container.gcp.upbound.io manifest
bde9b51 
Signed-off-by: Erhan Cagirici <[email protected]>
@erhancagirici @ulucinar
fix typo in manual intervention annotations
0c4e81e 
Signed-off-by: Erhan Cagirici <[email protected]>
@sergenyalcin @ulucinar
Fix the external name configuration of sql.SSLCert resource
c8607c4 
Signed-off-by: Sergen Yalçın <[email protected]>
@turkenf @ulucinar
Add random name for bucket in ProjectUsageExportBucket
30570f0 
Signed-off-by: Fatih Türken <[email protected]>
@ulucinar
Fix Reservation.compute update loop via config.Resource.TerraformCust…
f282c88 
…omDiff

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar
Fix V2Job.cloudrun update loop via config.Resource.TerraformCustomDiff
9c650dc 
- Terraform registry docs state that when the `launch_stage` argument
  is set, the attribute may differ from it. Thus, the provided example
  manifests ignore changes to this argument using the`ignore_changes`
  lifecycle meta-argument.

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar
Bump upjet to commit 77613fda2c6c
686a16f 
- Now we pass the Terraform customize diff function for all
  resources in the provider to the call schema.schemaMap.Diff.

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@erhancagirici @ulucinar
Fix NodePool.container update loop via config.Resource.TerraformCusto…
42bc4a7 
…mDiff

Signed-off-by: Erhan Cagirici <[email protected]>
@erhancagirici @ulucinar
Fix InstanceTemplate.compute update loop via config.Resource.Terrafor…
2b44890 
…mCustomDiff

Signed-off-by: Erhan Cagirici <[email protected]>
@erhancagirici @ulucinar
Fix InstanceFromTemplate.compute update loop via config.Resource.Terr…
cbef0b9 
…aformCustomDiff

Signed-off-by: Erhan Cagirici <[email protected]>
@turkenf @ulucinar
Add location field to the Connection.bigquery resource
c753a33 
Signed-off-by: Fatih Türken <[email protected]>
@sergenyalcin @ulucinar
Consume the wildcard fix from forked repo
b718ddf 
Signed-off-by: Sergen Yalçın <[email protected]>
@sergenyalcin @ulucinar
- Bump upjet dependency to the cf1b3462e748930a36eb6684e6b580045b5b39…
fab31ae 
…59 commit

- Bump crossplane-runtime dependency to the 0b379538ab149eab2573c38d28da642c11dcc263 commit

Signed-off-by: Sergen Yalçın <[email protected]>
@ulucinar
Remove the deprecated rand.Seed calls from the generated provider mains
72578ec 
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar
Bump crddiff to v0.8.0 and enable crddiff's upjet extensions
c07bc27 
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
sergenyalcin
sergenyalcin approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

turkenf
turkenf approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@turkenf turkenf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM.

@ulucinar ulucinar merged commit 24c3b92 into crossplane-contrib:main Dec 13, 2023
9 checks passed
@ulucinar ulucinar deleted the no-fork-v4.77.0 branch December 13, 2023 08:46
@ulucinar ulucinar mentioned this pull request Dec 13, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erhancagirici erhancagirici erhancagirici approved these changes

@turkenf turkenf turkenf approved these changes

@sergenyalcin sergenyalcin sergenyalcin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ulucinar @erhancagirici @turkenf @sergenyalcin