-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example manifests for v1beta2 version #746
Merged
sergenyalcin
merged 3 commits into
crossplane-contrib:main
from
sergenyalcin:add-v1beta2-examples
May 21, 2024
Merged
Add example manifests for v1beta2 version #746
sergenyalcin
merged 3 commits into
crossplane-contrib:main
from
sergenyalcin:add-v1beta2-examples
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
sergenyalcin
force-pushed
the
add-v1beta2-examples
branch
from
May 21, 2024 10:55
02b2bac
to
f81277b
Compare
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
force-pushed
the
add-v1beta2-examples
branch
from
May 21, 2024 12:49
f81277b
to
eae946f
Compare
Signed-off-by: Sergen Yalçın <[email protected]>
ulucinar
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sergenyalcin, lgtm. Let's point to the commit in the PR description that contains the manifest converter utility for future reference.
3 tasks
Upgrade Test
Upgrade test successful Downgrade Test
Downgrade test successful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR depends on #733.
This PR adds example manifests for
v1beta2
version.In this PR, for converting the example manifests, we used the following library: crossplane/upjet#397. For running this library, we need to add a main.go to the provider. Because of this is a one time work, we do not want to merge this converter to provider. However, for being reference we pushed and removed as commits for users: eae946f
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested