Decrease linter's memory usage #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Limit linter runner concurrency to 1 - Set GOGC to 50% for both lint phases - Set linter runner timeout to 90min Signed-off-by: Alper Rifat Ulucinar <[email protected]>
|
/test-examples="examples/network/subnet.yaml" |
sergenyalcin
approved these changes
Apr 2, 2024
|
Successfully created backport PR #693 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Relevant PR: crossplane-contrib/provider-upjet-aws#1217
This PR decreases the linter runner's memory footprint using a combination of techniques discussed in more detail in crossplane-contrib/provider-upjet-aws#1217. We could try to optimize the parameters that this PR proposes for the Azure provider, but let's defer it until we need those optimizations. The current parameters proposed here are probably more tight than what's necessary as the AWS provider is a larger provider.
Because of the
hdinsightgroup, which themisspelllinter treats as a misspelling of "hindsight", this PR disables themisspelllinter on all of the generated files.This PR also bumps the
kindversion used in uptest runs tov0.21.0and thegolangci-lintversion to1.55.2.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Validated locally by running
make lint. Also introduced a linter error and observed that the linter can successfully detect it.