Use Terraform Plugin SDK to Reconcile MRs #592
Conversation
|
/test-examples="examples/azure/resourcegroup.yaml" |
ulucinar
force-pushed
the
no-fork-v3.57.0
branch
from
cc15a2e to
a821069
Compare
|
/test-examples="examples/azure/resourcegroup.yaml" |
|
/test-examples="examples/azure/resourcegroup.yaml" |
ulucinar
changed the title
ulucinar
force-pushed
the
no-fork-v3.57.0
branch
from
a821069 to
55db9b8
Compare
|
/test-examples="examples/azure/resourcegroup.yaml" |
|
A test with (an earlier version of) |
|
/test-examples="examples/azure/resourcegroup.yaml" |
|
/test-examples="examples/network/subnet.yaml" |
|
/test-examples="examples/containerservice/kubernetescluster.yaml" |
|
/test-examples="examples/network/subnet.yaml" |
ulucinar
force-pushed
the
no-fork-v3.57.0
branch
from
2674766 to
2f885c0
Compare
|
/test-examples="examples/web/appactiveslot.yaml" |
|
/test-examples="examples/web/apphybridconnection.yaml" |
|
/test-examples="examples/web/functionappactiveslot.yaml" |
|
/test-examples="examples/web/appactiveslot.yaml" |
|
/test-examples="examples/web/sourcecontroltoken.yaml" |
|
/test-examples="examples/web/linuxwebappslot.yaml" |
|
/test-examples="examples/web/appserviceplan.yaml" |
|
/test-examples="examples/managedidentity/federatedidentitycredential.yaml" |
|
/test-examples="examples/containerservice/kubernetesfleetmanager.yaml" |
|
/test-examples="examples/logz/subaccounttagrule.yaml" |
|
/test-examples="examples/azure/resourcegroup.yaml" |
1 similar comment
|
/test-examples="examples/azure/resourcegroup.yaml" |
|
/test-examples="examples/logz/subaccounttagrule.yaml" |
…mple Signed-off-by: Erhan Cagirici <[email protected]>
…de662d12077 commit to consume the caching ID fix Signed-off-by: Sergen Yalçın <[email protected]>
…ommit Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
Historically, some resources were explicitly marked to use sync mode due to gain performance, however this is not needed anymore with the no-fork architecture. Async mode is safer especially for resources with long creation time Following resources are set back to the default async configuration: - azurerm_api_management - azurerm_subscription - azurerm_resource_provider_registration - azurerm_management_group - azurerm_mariadb_configuration - azurerm_ip_group - azurerm_network_interface - azurerm_network_watcher - azurerm_network_watcher_flow_log - azurerm_network_connection_monitor - azurerm_network_ddos_protection_plan - azurerm_network_security_rule - azurerm_network_profile - azurerm_private_dns_a_record - azurerm_private_dns_aaaa_record - azurerm_private_dns_mx_record - azurerm_private_dns_ptr_record - azurerm_private_dns_srv_record - azurerm_private_dns_txt_record - azurerm_frontdoor - azurerm_application_security_group - azurerm_private_dns_zone - azurerm_public_ip - azurerm_public_ip_prefix - azurerm_network_security_group - azurerm_virtual_network - azurerm_postgresql_flexible_server_configuration - azurerm_postgresql_configuration - azurerm_mssql_server_transparent_data_encryption - azurerm_storage_sync Signed-off-by: Erhan Cagirici <[email protected]>
Signed-off-by: Erhan Cagirici <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
…age.ManagementPolicy resources. - Fix efrontdoor-all-in-one.yaml example manifest Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
…mDiff Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
- Add custom diffs to three computer resources Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Erhan Cagirici <[email protected]>
Signed-off-by: Erhan Cagirici <[email protected]>
…ent example Signed-off-by: Sergen Yalçın <[email protected]>
…ment Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Erhan Cagirici <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
no-fork-v3.57.0
branch
from
88628df to
9d67f2f
Compare
|
/test-examples="examples/azure/resourcegroup.yaml" |
|
Hi @sergenyalcin, |
- azurerm_api_management_gateway.api_management_id - azurerm_resource_group_policy_assignment.resource_group_id - azurerm_container_connected_registry.container_registry_id - azurerm_container_registry_webhook.registry_name - azurerm_storage_encryption_scope.storage_account_id - azurerm_storage_management_policy.storage_account_id Signed-off-by: Sergen Yalçın <[email protected]>
@ulucinar I checked this. We have external name configuration fixes for the six resources in this PR. Because of the external name configuration templated fixes, some fields are marked as IdentifierField. We do not generate IdentifierFields in InitProvider. The reason for the diff is this. I removed these fields from the |
|
/test-examples="examples/azure/resourcegroup.yaml" |
Description of your changes
This PR employs the
controller.noForkExternal&controller.noForkAsyncExternalexternal clients from upjet to reconcile MRs without forking any Terraform CLI or Terraform provider processes.Some more details on these clients can be found here.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested