Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "branch_name", "version" and "regorg" parameters to the "Publish Service Artifacts" workflow #925

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

ulucinar
Copy link
Collaborator

Description of your changes

This PR parameterizes the image registry and repo, the branch name and the version used for building and publishing the provider packages so that we can still use the reusable workflow Provider Publish Service Artifacts for publishing packages to repositories other than xpkg.upbound.io/upbound and with customizable version strings.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Parts of the underlying reusable workflow has been tested in another organization. The calling workflow has not been tested.

"Publish Service Artifacts" workflow.

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar merged commit b05b0e9 into crossplane-contrib:main Oct 12, 2023
8 checks passed
@ulucinar ulucinar deleted the parameterize-regorg branch October 12, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants