Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular management policies - promote to BETA #906

Closed
wants to merge 3 commits into from

Conversation

lsviben
Copy link
Contributor

@lsviben lsviben commented Oct 3, 2023

Description of your changes

⚠️ This PR should be merged after Crossplane 1.14 is out, as we officialy promote GMP to BETA with 1.14

Bumped upjet(to an unreleased version) and crossplane runtime.
Updated the feature flag to be true by default, and the hack main.go.tmpl to use the beta flag.
Ran make generate

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Created a dynamodb Table with initProvider and managementPolicies:

apiVersion: dynamodb.aws.upbound.io/v1beta1
kind: Table
metadata:
  name: example
  annotations:
    meta.upbound.io/example-id: dynamodb/v1beta1/table
spec:
  managementPolicies: ["Observe", "Create", "Update", "Delete"]
  initProvider:
    tags:
      toIgnore: placeholder
    writeCapacity: 20
    readCapacity: 19
  forProvider:
    region: us-west-1
    attribute:
    - name: UserId
      type: S
    - name: GameTitle
      type: S
    - name: TopScore
      type: "N"
    billingMode: PROVISIONED
    globalSecondaryIndex:
    - hashKey: GameTitle
      name: GameTitleIndex
      nonKeyAttributes:
      - UserId
      projectionType: INCLUDE
      rangeKey: TopScore
      readCapacity: 10
      writeCapacity: 10
    hashKey: UserId
    rangeKey: GameTitle
kubectl get -f table.yaml 
NAME      READY   SYNCED   EXTERNAL-NAME   AGE
example   True    True     example         14m

@lsviben lsviben requested a review from turkenh October 3, 2023 13:02
Signed-off-by: lsviben <[email protected]>
Signed-off-by: lsviben <[email protected]>
@turkenf
Copy link
Collaborator

turkenf commented Oct 12, 2023

Covered in #918

@turkenf turkenf closed this Oct 12, 2023
@turkenf
Copy link
Collaborator

turkenf commented Oct 12, 2023

Many thanks to @lsviben for preparing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants