Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to publish family provider docs for updoc workflow #880

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Sep 14, 2023

Description of your changes

Consumes reusable workflows introduced in upbound/official-providers-ci#134

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually tested on turkenf/uptest and turkenf/provider-gcp

@turkenf turkenf marked this pull request as draft September 15, 2023 08:41
@turkenf turkenf changed the title Add ability to publish family providers for updoc workflow Add ability to publish family provider docs for updoc workflow Sep 27, 2023
@turkenf turkenf marked this pull request as ready for review September 27, 2023 14:24
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf, lgtm. Please do not forget to rename the public-pack parameter here if you decide to do so in the uptest PR.

@turkenf turkenf force-pushed the update-updoc-workflow branch from d502333 to 6a1e3f1 Compare September 27, 2023 19:53
@turkenf turkenf merged commit 6d374e5 into crossplane-contrib:main Sep 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants