-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reference for Configuration to kafka cluster #877
Merged
turkenf
merged 7 commits into
crossplane-contrib:main
from
spanio:matt/kafka-configuration-ref-4.67
Sep 22, 2023
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e1703cf
add two selectors for kafka configuration
mbbush 5db43cd
codegen kafka configuration references
mbbush 6a12b9c
Use ExtractParamPath
mbbush 02ed2d8
update kafka cluster example
mbbush 4a6eb32
update firehose config in kafka example
mbbush 1a05feb
Remove revision selector because it's not a string
mbbush 84ce0b3
move example to us-east-2 which has more AZs than us-west-1
mbbush File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
package v1beta1 | ||
|
||
import ( | ||
"github.com/crossplane/crossplane-runtime/pkg/fieldpath" | ||
"github.com/crossplane/crossplane-runtime/pkg/reference" | ||
xpresource "github.com/crossplane/crossplane-runtime/pkg/resource" | ||
) | ||
|
||
// Lovingly ripped off from config/common/ARNExtractor. Is there a better way? | ||
func GetConfigurationRevision() reference.ExtractValueFn { | ||
return func(mg xpresource.Managed) string { | ||
paved, err := fieldpath.PaveObject(mg) | ||
if err != nil { | ||
// todo(hasan): should we log this error? | ||
return "" | ||
} | ||
r, err := paved.GetString("status.atProvider.revision") | ||
if err != nil { | ||
// todo(hasan): should we log this error? | ||
return "" | ||
} | ||
return r | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a function for such situations, could you please try the configuration above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I thought I remembered seeing something like that, and looked for it, but couldn't find it. This is much better.