-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure iam.RolePolicy
resource and add example manifest
#770
Conversation
/test-examples="examples/iam/rolepolicy.yaml" |
We're seeing performance problems with |
6f6a1a7
to
9663107
Compare
9663107
to
f1bf0a9
Compare
@blakebarnett, we expect the situation to become clearer this week(regarding this PR), but we cannot provide a definite date for now regarding when it will be finalized. We appreciate your patience and understanding during this process. If you have any further questions or concerns, please feel free to let us know. |
/test-examples="examples/iam/rolepolicy.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @turkenf I left a comment about external name configuration
/test-examples="examples/iam/rolepolicy.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @turkenf LGTM!
Description of your changes
This PR includes configuring the
iam.RolePolicy
resource and adding the example manifest.Related issue: #170, related PR: #745
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Manually and Uptest: https://github.com/upbound/provider-aws/actions/runs/6000658175