Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure iam.RolePolicy resource and add example manifest #770

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Jul 3, 2023

Description of your changes

This PR includes configuring the iam.RolePolicy resource and adding the example manifest.

Related issue: #170, related PR: #745

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually and Uptest: https://github.com/upbound/provider-aws/actions/runs/6000658175

NAME                                READY   SYNCED   EXTERNAL-NAME   AGE
role.iam.aws.upbound.io/test-role   True    True     test-role       9m43s

NAME                                        READY   SYNCED   EXTERNAL-NAME           AGE
rolepolicy.iam.aws.upbound.io/test-policy   True    True     test-role:test_policy   9m43s

@turkenf
Copy link
Collaborator Author

turkenf commented Jul 3, 2023

/test-examples="examples/iam/rolepolicy.yaml"

@blakebarnett
Copy link

We're seeing performance problems with provider-family-aws-iam and this would be helpful to eliminate a bunch of managed resources. Any major reason it hasn't made it in yet?

@turkenf
Copy link
Collaborator Author

turkenf commented Aug 28, 2023

We're seeing performance problems with provider-family-aws-iam and this would be helpful to eliminate a bunch of managed resources. Any major reason it hasn't made it in yet?

@blakebarnett, we expect the situation to become clearer this week(regarding this PR), but we cannot provide a definite date for now regarding when it will be finalized. We appreciate your patience and understanding during this process. If you have any further questions or concerns, please feel free to let us know.

@turkenf
Copy link
Collaborator Author

turkenf commented Aug 28, 2023

/test-examples="examples/iam/rolepolicy.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf I left a comment about external name configuration

config/externalname.go Outdated Show resolved Hide resolved
@turkenf
Copy link
Collaborator Author

turkenf commented Aug 29, 2023

/test-examples="examples/iam/rolepolicy.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf LGTM!

@turkenf turkenf merged commit 4beac7a into crossplane-contrib:main Aug 29, 2023
8 checks passed
@turkenf turkenf deleted the add-role-policy branch August 29, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants