Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ses smtp accesskey #718

Conversation

alexinthesky
Copy link
Contributor

Description of your changes

re-add region to aws_iam_access_key
Fixes #717

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Copy link
Contributor

@turkenh turkenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @alexinthesky 🙌

config/overrides.go Show resolved Hide resolved
config/overrides.go Outdated Show resolved Hide resolved
@turkenf
Copy link
Collaborator

turkenf commented Jun 9, 2023

/test-examples="examples/iam/user.yaml"

Copy link
Contributor

@turkenh turkenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this would indeed be a breaking change for IAM AccessKey resource users since their existing resource will start failing with the lack of region parameter.

I think we would also need to add it as optional instead of required.

@turkenf
Copy link
Collaborator

turkenf commented Jul 21, 2023

Hi, @alexinthesky are you still interested in moving this PR forward?

@turkenf
Copy link
Collaborator

turkenf commented Sep 27, 2023

@alexinthesky, I'm closing this PR for now, if you're still interested and want to move it forward, feel free to reopen it.

@turkenf turkenf closed this Sep 27, 2023
@tdjordan
Copy link

I am running into a situation where I want to create an AccessKey for a User but get the ses_smtp_password_v4 for a different region than what is generated by default.

For example, the ses_smtp_password_v4 for us-west-2 instead of the currently generated one for us-east-2.

I am interested in re-opening this PR to allow the region to be specified for the aws_iam_access_key resource.

What is needed for me to do to help drive this PR into an acceptable merge state?

I have little experience in go but am willing to learn and facilitate.

Alternatively, I have looked at the surrounding code and it is currently unclear to me what is populating the Region in the AWSCLient context. Could someone point me in the right direction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iam accesskey smtp password generation fails
4 participants