-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ses smtp accesskey #718
Fix ses smtp accesskey #718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @alexinthesky 🙌
/test-examples="examples/iam/user.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this would indeed be a breaking change for IAM AccessKey resource users since their existing resource will start failing with the lack of region
parameter.
I think we would also need to add it as optional instead of required.
Hi, @alexinthesky are you still interested in moving this PR forward? |
@alexinthesky, I'm closing this PR for now, if you're still interested and want to move it forward, feel free to reopen it. |
I am running into a situation where I want to create an AccessKey for a User but get the For example, the I am interested in re-opening this PR to allow the region to be specified for the What is needed for me to do to help drive this PR into an acceptable merge state? I have little experience in Alternatively, I have looked at the surrounding code and it is currently unclear to me what is populating the Region in the AWSCLient context. Could someone point me in the right direction? |
Description of your changes
re-add region to aws_iam_access_key
Fixes #717
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested