Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam): added username and password for iam accesskey connection-secret #644

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Apr 2, 2023

Description of your changes

add username and password for iam accesskey connection secret like community provider-aws

community provider-aws:

apiVersion: v1
data:
  password: *****
  username: *****

official provider-aws:

apiVersion: v1
data:
  attribute.secret: *****
  attribute.ses_smtp_password_v4: *****

after that PR we have 2 additional keys for official provider-aws:

apiVersion: v1
data:
  attribute.secret: *****
  attribute.ses_smtp_password_v4: *****
  password: *****
  username: *****

think today its not possible to run an uptest action for this AdditionalConnectionDetailsFn we have one open issue for that: upbound/official-providers-ci#82

Fixes #479

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

create user.yaml and checked secret

NAME                                  READY   SYNCED   EXTERNAL-NAME   AGE
user.iam.aws.upbound.io/sample-user   True    True     sample-user     84s

NAME                                             READY   SYNCED   EXTERNAL-NAME          AGE
accesskey.iam.aws.upbound.io/sample-access-key   True    True     AKIAWLLR7LGH24LYMW5R   84s

NAME                       TYPE                                DATA   AGE
sample-access-key-secret   connection.crossplane.io/v1alpha1   4      85s

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haarchri LGTM!

@sergenyalcin sergenyalcin merged commit 0b639ce into crossplane-contrib:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iam: AccessKey CRD connection attributes missing + strange...
2 participants