Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of rule.filter.prefix field for BucketLifecycleConfiguration.s3 #1331

Merged
merged 1 commit into from
May 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions apis/s3/v1beta1/zz_bucketlifecycleconfiguration_types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions config/s3/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,9 @@ func Configure(p *config.Provider) {
Extractor: `github.com/crossplane/upjet/pkg/resource.ExtractParamPath("arn",true)`,
}
})

p.AddResourceConfigurator("aws_s3_bucket_lifecycle_configuration", func(r *config.Resource) {
r.MetaResource.ArgumentDocs["rule.filter.prefix"] = `- (Optional) Prefix identifying one or more objects to which the rule applies. Defaults to an empty string ("") if not specified.`
r.MetaResource.ArgumentDocs["rule.filter.and.prefix"] = `- (Optional) Prefix identifying one or more objects to which the rule applies.`
})
}
42 changes: 15 additions & 27 deletions package/crds/s3.aws.upbound.io_bucketlifecycleconfigurations.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,8 @@ spec:
to which the rule applies.
type: number
prefix:
description: DEPRECATED Use filter instead.
This has been deprecated by Amazon S3. Prefix
identifying one or more objects to which the
rule applies. Defaults to an empty string
("") if filter is not specified.
description: Prefix identifying one or more
objects to which the rule applies.
type: string
tags:
additionalProperties:
Expand All @@ -253,10 +250,9 @@ spec:
the rule applies.
type: string
prefix:
description: DEPRECATED Use filter instead. This has
been deprecated by Amazon S3. Prefix identifying
one or more objects to which the rule applies. Defaults
to an empty string ("") if filter is not specified.
description: Prefix identifying one or more objects
to which the rule applies. Defaults to an empty
string ("") if not specified.
type: string
tag:
description: Configuration block for specifying a
Expand Down Expand Up @@ -518,11 +514,8 @@ spec:
to which the rule applies.
type: number
prefix:
description: DEPRECATED Use filter instead.
This has been deprecated by Amazon S3. Prefix
identifying one or more objects to which the
rule applies. Defaults to an empty string
("") if filter is not specified.
description: Prefix identifying one or more
objects to which the rule applies.
type: string
tags:
additionalProperties:
Expand All @@ -543,10 +536,9 @@ spec:
the rule applies.
type: string
prefix:
description: DEPRECATED Use filter instead. This has
been deprecated by Amazon S3. Prefix identifying
one or more objects to which the rule applies. Defaults
to an empty string ("") if filter is not specified.
description: Prefix identifying one or more objects
to which the rule applies. Defaults to an empty
string ("") if not specified.
type: string
tag:
description: Configuration block for specifying a
Expand Down Expand Up @@ -900,11 +892,8 @@ spec:
to which the rule applies.
type: number
prefix:
description: DEPRECATED Use filter instead.
This has been deprecated by Amazon S3. Prefix
identifying one or more objects to which the
rule applies. Defaults to an empty string
("") if filter is not specified.
description: Prefix identifying one or more
objects to which the rule applies.
type: string
tags:
additionalProperties:
Expand All @@ -925,10 +914,9 @@ spec:
the rule applies.
type: string
prefix:
description: DEPRECATED Use filter instead. This has
been deprecated by Amazon S3. Prefix identifying
one or more objects to which the rule applies. Defaults
to an empty string ("") if filter is not specified.
description: Prefix identifying one or more objects
to which the rule applies. Defaults to an empty
string ("") if not specified.
type: string
tag:
description: Configuration block for specifying a
Expand Down
Loading