Set log.Default's output to io.Discard #1215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #974
Fixes #854
This PR sets a default
io.Discard
logger for the controller-runtime if debug logging is not enabled. If debug logging is enabled, then the controller-runtime uses a debug mode zap logger as usual.It also sets the log.Default's output to io.Discard. According to our experiments with a
VPC.ec2
and aCluster.eks
, this prevents the noisy logs from the underlying Terraform provider. We still need to check for direct log messages via thefmt
variants, such asfmt.Println
.In a further iteration, we will also consider making the underlying provider's logs available in a structured format.
This PR also switches to the
standard-runners
branch ofupbound/uptest
because the larger runners are not available in thecrossplane-contrib
organization.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Tested manually with
VPC.ec2
&Cluster.eks
example manifests. TheCluster.eks
has dependencies from theec2
&iam
API groups.