Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying license changes #1212

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

sergenyalcin
Copy link
Collaborator

@sergenyalcin sergenyalcin commented Mar 13, 2024

Description of your changes

This PR applies license changes.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested via Uptest: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/8281184177

@sergenyalcin sergenyalcin force-pushed the licence-updates branch 2 times, most recently from ad3b2ce to 2cbeef2 Compare March 14, 2024 11:49
Signed-off-by: Sergen Yalçın <[email protected]>
@sergenyalcin
Copy link
Collaborator Author

/test-examples="examples/ec2/v1beta1/vpc.yaml"

Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sergenyalcin. lgtm. Looks like we need to add the license header back to upjet's setup.go.tmpl so that the license headers are present for the files internal/controller/*.go.

@sergenyalcin sergenyalcin merged commit 74d77de into crossplane-contrib:main Mar 14, 2024
12 checks passed
@sergenyalcin sergenyalcin deleted the licence-updates branch March 14, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants