Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Test PR #1210

Closed
wants to merge 2 commits into from
Closed

Conversation

ulucinar
Copy link
Collaborator

Description of your changes

Fixes #

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar ulucinar marked this pull request as draft March 12, 2024 17:30
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/eks/v1beta1/cluster.yaml"

@ulucinar ulucinar closed this Mar 12, 2024
@ulucinar ulucinar reopened this Mar 12, 2024
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/eks/v1beta1/cluster.yaml"

@ulucinar ulucinar force-pushed the test-pr branch 2 times, most recently from 0998e34 to 71408cb Compare March 13, 2024 02:18
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar
Copy link
Collaborator Author

We've observed some instability with the linter in this PR: Our previous observation was we could run the second (full linting) phase with the maximum concurrency but the second phase has failed two times in the runs for this PR. We have also observed successful runs with the current parameters. But as a precaution, I currently believe it's a good idea to also limit its concurrency (as we've already done for the initial cache construction phase) and to run the disk cleanup job to allow for more virtual memory space. The latest successful run of the linter in this PR is with a concurrency of 3. We've also verified the linter can actually point to issues in this run:
image

We've also a recorded successful run for uptest for the examples/eks/v1beta1/cluster.yaml example manifest here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant