Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ignore_tags_prefixes to provider configuration #1178

Closed

Conversation

kirek007
Copy link

Description of your changes

Fixes #1177

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Code was manually tested against my own aws accounts

@Upbound-CLA
Copy link

Upbound-CLA commented Feb 28, 2024

CLA assistant check
All committers have signed the CLA.

@kirek007 kirek007 force-pushed the feat/provider-ignore-tags branch from 32d52fc to 7d3fe0b Compare February 28, 2024 11:47
@kirek007 kirek007 marked this pull request as ready for review February 28, 2024 11:48
@mbbush
Copy link
Collaborator

mbbush commented Apr 22, 2024

@kirek007 Are you still interested in moving this PR forward?

@kirek007
Copy link
Author

@kirek007 Are you still interested in moving this PR forward?

Hey, I'll fix typo this evening and rebase PR

@kirek007
Copy link
Author

@mbbush Sorry, but due to latest changes to code this PR is no longer valid I'll close it for now and check what was changed and adjust code if needed.

@kirek007 kirek007 closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore tags managed by external party
3 participants