[Backport release-0.47] tests and testing changes #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable the import test for examples/s3/v1beta1/object.yaml Please see: crossplane-contrib#978 Signed-off-by: Alper Rifat Ulucinar <[email protected]> Signed-off-by: Matt Bush <[email protected]>
mbbush
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
mbbush
changed the title
|
/test-examples="examples/elasticache/replicationgroup.yaml" I think this will fail, as I don't believe upjet has been patched on this branch yet. |
|
The above uptest run for the |
ulucinar
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Thanks @mbbush, lgtm.
We have also successfully validated the following resources in a rebased branch in #1163:
- examples/secretsmanager/secret.yaml -> https://github.com/upbound/provider-aws/actions/runs/7931148364
- examples/secretsmanager/secret-withreplica.yaml -> https://github.com/upbound/provider-aws/actions/runs/7931145760
- examples/s3/object.yaml -> https://github.com/upbound/provider-aws/actions/runs/7931138724
- examples/networkfirewall/firewall.yaml -> https://github.com/upbound/provider-aws/actions/runs/7931135762. Looks like we have an issue with uptest causing it to skip update tests in certain situations. However, this resource has already been validated with the update step in https://github.com/upbound/provider-aws/actions/runs/7930174691.
- examples/elasticache/replicationgroup.yaml -> https://github.com/upbound/provider-aws/actions/runs/7931140738
- examples/ec2/securitygroupegressrule.yaml -> https://github.com/upbound/provider-aws/actions/runs/7931601796
Due to an issue with our CI pipelines, we have also locally run the following steps manually:
check-diffunit-tests- local-deploy is already covered by the uptest runs.
ulucinar
merged commit a66ec4a
into
crossplane-contrib:release-0.47
6 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Backporting some test/testing fixes from main.
The elasticache replication group example had a fix in upjet, so this is a good test to run to see if we've picked that into the release branch correctly.
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Please see this comment for the details on testing of this PR.