Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump crossplane-runtime to commit 7fcb8c5cad6f #1159

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Feb 15, 2024

Description of your changes

This PR bumps crossplane-runtime dependency to the commit 7fcb8c5cad6f to consume crossplane/crossplane-runtime#666. It also bumps upjet to v1.2.0.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Via the following uptest runs:

@ulucinar
Copy link
Collaborator Author

/test-examples="examples/ec2/v1beta2/route.yaml"

@sergenyalcin
Copy link
Collaborator

/test-examples="examples/opensearchserverless/v1beta1/accesspolicy.yaml,examples/opensearchserverless/v1beta1/lifecyclepolicy.yaml,examples/opensearchserverless/v1beta1/securitypolicy.yaml,examples/opensearchserverless/v1beta1/securityconfig.yaml"

- Consume the fix for fieldpath.getValueFromInterface from crossplane-runtime
- Bump upjet to v1.2.0

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar ulucinar force-pushed the bump-crossplane-runtime branch from ab6e8b5 to 6ae7da0 Compare February 15, 2024 16:57
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/ec2/v1beta2/route.yaml"

@sergenyalcin
Copy link
Collaborator

/test-examples="examples/opensearchserverless/v1beta1/accesspolicy.yaml,examples/opensearchserverless/v1beta1/lifecyclepolicy.yaml,examples/opensearchserverless/v1beta1/securitypolicy.yaml,examples/opensearchserverless/v1beta1/securityconfig.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar merged commit 069ec0a into crossplane-contrib:main Feb 15, 2024
11 checks passed
@ulucinar ulucinar deleted the bump-crossplane-runtime branch February 15, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants