[Backport release-0.47] fix Secret/secretmanagers.aws update loop for replica field and custom diff logic when replica config is empty #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erhan Cagirici <[email protected]> (cherry picked from commit 456d8d3)
turkenf
changed the title
… empty Signed-off-by: Erhan Cagirici <[email protected]> (cherry picked from commit 8d35a82)
(cherry picked from commit 3df0d8d)
turkenf
changed the title
|
/test-examples="examples/secretsmanager/secret.yaml" |
|
/test-examples="examples/secretsmanager/secret-withreplica.yaml" |
Signed-off-by: Sergen Yalçın <[email protected]>
|
/test-examples="examples/secretsmanager/secret.yaml" Uptest run: https://github.com/upbound/provider-aws/actions/runs/7917258418 |
|
/test-examples="examples/secretsmanager/secret-withreplica.yaml" Uptest run: https://github.com/upbound/provider-aws/actions/runs/7917600558 |
|
Because of the shared runner out-of-memory issues, for now, we ran the following jobs locally:
Also, the |
ulucinar
approved these changes
Feb 16, 2024
sergenyalcin
merged commit f0f1504
into
crossplane-contrib:release-0.47
8 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #1107 and #1144 to
release-0.47.Tests: