Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-0.47] Make endpoint provider configuration value single-element list #1156

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Feb 15, 2024

Description

Backport of #1066 to release-0.47.

Uptest Run: https://github.com/upbound/provider-aws/actions/runs/7929858398

Signed-off-by: Erhan Cagirici <[email protected]>
(cherry picked from commit 459bd0b)
@sergenyalcin
Copy link
Collaborator

sergenyalcin commented Feb 16, 2024

/test-examples="examples/ec2/vpc.yaml"

Uptest run: https://github.com/upbound/provider-aws/actions/runs/7929858398

@sergenyalcin
Copy link
Collaborator

Because of the shared runner out-of-memory issues, for now, we ran the following jobs locally:

  • check-diff (locally passed) ✅
  • unit-tests (locally passed) ✅

Also, the uptest runs cover the local-deploy job. In other words, in uptest runs, we ensure that the packages are correctly deployed because the work done in local-deploy is done.

Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf, lgtm.

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf LGTM!

@sergenyalcin sergenyalcin merged commit 0fb67a6 into crossplane-contrib:release-0.47 Feb 16, 2024
13 of 19 checks passed
@turkenf turkenf deleted the backport-1066-to-release-0.47 branch February 16, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants