Function type config.ConfigurationInjector now returns an error #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples="examples/s3/v1beta1/object.yaml" |
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
change-configinjector
branch
from
28297b9 to
3fad811
Compare
|
/test-examples="examples/s3/v1beta1/object.yaml" |
sergenyalcin
approved these changes
Feb 14, 2024
|
Looks like we've hit this issue with the |
- Disable the import test for examples/s3/v1beta1/object.yaml Please see: crossplane-contrib#978 Signed-off-by: Alper Rifat Ulucinar <[email protected]>
|
/test-examples="examples/s3/v1beta1/object.yaml" |
1 similar comment
|
/test-examples="examples/s3/v1beta1/object.yaml" |
|
/test-examples="examples/s3/v1beta1/bucket.yaml" |
Merged
3 tasks
- Consumes the config.ConfigurationInjector signature change Signed-off-by: Alper Rifat Ulucinar <[email protected]>
|
/test-examples="examples/ec2/v1beta1/securitygrouprule-self-true.yaml" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Depends on: crossplane/upjet#344
There's a breaking change in crossplane/upjet#344 and
config.ConfigurationInjectornow returns an error. This PR updates the usages of the old API.This PR also bumps the uptest version to
v0.11.0and adds theuptest.upbound.io/disable-import: "true"annotation to the example manifestexamples/s3/v1beta1/object.yaml. Please see this comment.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Via the following uptest runs: