Add aws_cloudformation_stack_set_instance resource #1129
Conversation
|
/test-examples="examples/cloudformation/v1beta1/stacksetinstance.yaml" |
sergenyalcin
force-pushed
the
configure-cloudformation_stack_set_instance
branch
from
89179a1 to
30b1377
Compare
|
/test-examples="examples/cloudformation/v1beta1/stacksetinstance.yaml" |
Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
force-pushed
the
configure-cloudformation_stack_set_instance
branch
from
30b1377 to
d606602
Compare
|
/test-examples="examples/cloudformation/v1beta1/stacksetinstance.yaml" |
There was a problem hiding this comment.
Thanks @sergenyalcin, lgtm.
My understanding is that we have also validated this resource via upjet, right? If so, could you please also update the description with a reference to the successful uptest run?
Signed-off-by: Sergen Yalçın <[email protected]>
Added to the description. |
| // Cloudformation Stacks Instances imported using the StackSet name, target | ||
| // AWS account ID, and target AWS region separated with commas: | ||
| // example,123456789012,us-east-1 |
There was a problem hiding this comment.
Terraform documentation states that these can be imported in two different format:
// StackSetInstances can be imported in two ways:
// If deployment_targets is set, use a comma-delimited string combining
// stack set name, organizational unit IDs ( / delimited), and region (i.e. mystack,ou-123/ou-456,us-east-1).
// Otherwise, use a comma-delimited string combining:
// stack set name, AWS account ID, and region (i.e. mystack,123456789012,us-east-1)
Description of your changes
Fixes #1078
Related #26
This PR adds
aws_cloudformation_stack_set_instanceresource.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested locally and via Uptest.