Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocDB: add dbClusterParameterGroupName Selector for Cluster #1070

Merged

Conversation

ytsarev
Copy link
Collaborator

@ytsarev ytsarev commented Jan 6, 2024

Description of your changes

Add dbClusterParameterGroupNameSelector to DocDB Cluster

  • Add reference configuration
  • Add generated files
  • Extend uptest example

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

uptest below

@ytsarev ytsarev marked this pull request as draft January 6, 2024 02:33
config/docdb/config.go Outdated Show resolved Hide resolved
@ytsarev ytsarev force-pushed the docdb-parameter-group-name-selector branch 3 times, most recently from 0f1f815 to f77080e Compare January 6, 2024 10:29
@ytsarev
Copy link
Collaborator Author

ytsarev commented Jan 6, 2024

/test-examples="examples/docdb/cluster.yaml"

…oupName

* config and generated files
* associated uptest example extension

Signed-off-by: Yury Tsarev <[email protected]>
@ytsarev ytsarev force-pushed the docdb-parameter-group-name-selector branch from f77080e to 6993dfd Compare January 6, 2024 11:36
@ytsarev
Copy link
Collaborator Author

ytsarev commented Jan 6, 2024

/test-examples="examples/docdb/cluster.yaml"

@ytsarev ytsarev marked this pull request as ready for review January 6, 2024 11:52
@ytsarev ytsarev requested a review from haarchri January 6, 2024 11:52
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ytsarev, lgtm.

Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM

@ytsarev ytsarev merged commit 5d2894e into crossplane-contrib:main Jan 6, 2024
10 checks passed
@ytsarev ytsarev deleted the docdb-parameter-group-name-selector branch January 6, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants