Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(late-init): Lambda Permission: statement_id_prefix late initialization problem #1004

Merged

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Dec 4, 2023

Description of your changes

  • fix statement_id_prefix
  • add working example

Fixes #1001

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Uptest: https://github.com/upbound/provider-aws/actions/runs/7091214720

@turkenf
Copy link
Collaborator

turkenf commented Dec 4, 2023

/test-examples="examples/lambda/permission.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @haarchri, LGTM.

@turkenf turkenf merged commit 1cdb099 into crossplane-contrib:main Dec 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lambda Permission: statement_id_prefix late initialization problem
2 participants