Fix the update loop in Firewall.networkfirewall resource

- Extend the example manifest for the Firewall.networkfirewall resource with some extra parameters and enable the update tests on it. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
crossplane-contrib · Feb 16, 2024 · e8b5f1a · e8b5f1a
1 parent 91d65fd
commit e8b5f1a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/config/networkfirewall/config.go b/config/networkfirewall/config.go
@@ -76,6 +76,9 @@ func Configure(p *config.Provider) { // nolint:gocyclo
 					}
 				}
 			}
+			if diff.Attributes != nil {
+				delete(diff.Attributes, "firewall_status.#")
+			}
 			return diff, nil
 		}
 	})

diff --git a/examples/networkfirewall/firewall.yaml b/examples/networkfirewall/firewall.yaml
@@ -4,11 +4,14 @@ metadata:
   annotations:
     uptest.upbound.io/timeout: "3600"
     meta.upbound.io/example-id: networkfirewall/v1beta1/firewall
+    uptest.upbound.io/update-parameter: '{"tags":{"update-test-tag":"val"}}'
   labels:
     testing.upbound.io/example-name: example
   name: firewallname
 spec:
   forProvider:
+    firewallPolicyChangeProtection: true
+    subnetChangeProtection: true
     firewallPolicyArnSelector:
       matchLabels:
         testing.upbound.io/example-name: example
-Original file line number
+Diff line change
@@ Expand Up / @@ -76,6 +76,9 @@ func Configure(p *config.Provider) { // nolint:gocyclo @@
     					}
     				}
     			}
+    			if diff.Attributes != nil {
+    				delete(diff.Attributes, "firewall_status.#")
+    			}
     			return diff, nil
     		}
     	})
@@ Expand Down @@