Remove ARN Parameter from Firehose Resource

Signed-off-by: Blake R <[email protected]>
crossplane-contrib · Mar 22, 2024 · affd2a0 · affd2a0
1 parent cacdcfc
commit affd2a0
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 37 deletions.
diff --git a/apis/firehose/v1beta1/zz_deliverystream_types.go b/apis/firehose/v1beta1/zz_deliverystream_types.go
diff --git a/apis/firehose/v1beta1/zz_generated.deepcopy.go b/apis/firehose/v1beta1/zz_generated.deepcopy.go
diff --git a/apis/firehose/v1beta1/zz_generated.resolvers.go b/apis/firehose/v1beta1/zz_generated.resolvers.go
diff --git a/config/firehose/config.go b/config/firehose/config.go
@@ -17,28 +17,30 @@ func Configure(p *config.Provider) {
 		r.TerraformResource.Schema["splunk_configuration"].Elem.(*schema.Resource).Schema["hec_token"].Sensitive = true
 
 		r.References["extended_s3_configuration.role_arn"] = config.Reference{
-			Type:      "github.com/upbound/provider-aws/apis/iam/v1beta1.Role",
-			Extractor: common.PathARNExtractor,
+			TerraformName: "aws_iam_role",
+			Extractor:     common.PathARNExtractor,
 		}
 		r.References["extended_s3_configuration.bucket_arn"] = config.Reference{
-			Type:      "github.com/upbound/provider-aws/apis/s3/v1beta1.Bucket",
-			Extractor: common.PathARNExtractor,
+			TerraformName: "aws_s3_bucket",
+			Extractor:     common.PathARNExtractor,
 		}
 
 		r.References["s3_configuration.role_arn"] = config.Reference{
-			Type:      "github.com/upbound/provider-aws/apis/iam/v1beta1.Role",
-			Extractor: common.PathARNExtractor,
+			TerraformName: "aws_iam_role",
+			Extractor:     common.PathARNExtractor,
 		}
 		r.References["s3_configuration.bucket_arn"] = config.Reference{
-			Type:      "github.com/upbound/provider-aws/apis/s3/v1beta1.Bucket",
-			Extractor: common.PathARNExtractor,
+			TerraformName: "aws_s3_bucket",
+			Extractor:     common.PathARNExtractor,
 		}
 
 		r.References["redshift_configuration.s3_backup_configuration.bucket_arn"] = config.Reference{
-			Type:      "github.com/upbound/provider-aws/apis/s3/v1beta1.Bucket",
-			Extractor: `github.com/crossplane/upjet/pkg/resource.ExtractParamPath("arn",true)`,
+			TerraformName: "aws_s3_bucket",
+			Extractor:     common.PathARNExtractor,
 		}
 
+		config.MoveToStatus(r.TerraformResource, "arn")
+
 		r.LateInitializer = config.LateInitializer{
 			IgnoredFields: []string{
 				"server_side_encryption",

diff --git a/package/crds/firehose.aws.upbound.io_deliverystreams.yaml b/package/crds/firehose.aws.upbound.io_deliverystreams.yaml
@@ -73,9 +73,6 @@ spec:
                 type: string
               forProvider:
                 properties:
-                  arn:
-                    description: The Amazon Resource Name (ARN) specifying the Stream
-                    type: string
                   destination:
                     description: –  This is the destination to where the data is delivered.
                       The only options are s3 (Deprecated, use extended_s3 instead),
@@ -4158,9 +4155,6 @@ spec:
                   for example because of an external controller is managing them, like an
                   autoscaler.
                 properties:
-                  arn:
-                    description: The Amazon Resource Name (ARN) specifying the Stream
-                    type: string
                   destination:
                     description: –  This is the destination to where the data is delivered.
                       The only options are s3 (Deprecated, use extended_s3 instead),