Merge pull request #1386 from haarchri/feature/nodegroup-version-desc…

…ription feat(eks): set correct description for field
crossplane-contrib · Jul 1, 2024 · 596f83b · 596f83b
2 parents 6bfa63b + 9a3d699
commit 596f83b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 22 deletions.
diff --git a/apis/eks/v1beta2/zz_nodegroup_types.go b/apis/eks/v1beta2/zz_nodegroup_types.go
diff --git a/config/eks/config.go b/config/eks/config.go
@@ -57,7 +57,7 @@ func Configure(p *config.Provider) {
 			},
 		}
 		r.UseAsync = true
-		r.MetaResource.ArgumentDocs["launch_template.version"] = `- (Required) EC2 Launch Template version number. While the API accepts values like $Default and $Latest, the API will convert the value to the associated version number (e.g., 1). Using the default_version or latest_version attribute of the aws_launch_template resource or data source is recommended for this argument.`
+		r.MetaResource.ArgumentDocs["launch_template.version"] = `- (Required) EC2 Launch Template version number.`
 		r.MetaResource.ArgumentDocs["subnet_ids"] = `- Identifiers of EC2 Subnets to associate with the EKS Node Group. Amazon EKS managed node groups can be launched in both public and private subnets. If you plan to deploy load balancers to a subnet, the private subnet must have tag kubernetes.io/role/internal-elb, the public subnet must have tag kubernetes.io/role/elb.`
 	})
 	p.AddResourceConfigurator("aws_eks_identity_provider_config", func(r *config.Resource) {

diff --git a/package/crds/eks.aws.upbound.io_nodegroups.yaml b/package/crds/eks.aws.upbound.io_nodegroups.yaml
@@ -1715,12 +1715,7 @@ spec:
                           id.
                         type: string
                       version:
-                        description: EC2 Launch Template version number. While the
-                          API accepts values like $Default and $Latest, the API will
-                          convert the value to the associated version number (e.g.,
-                          1). Using the default_version or latest_version attribute
-                          of the aws_launch_template resource or data source is recommended
-                          for this argument.
+                        description: EC2 Launch Template version number.
                         type: string
                     type: object
                   nodeRoleArn:
@@ -2190,12 +2185,7 @@ spec:
                           id.
                         type: string
                       version:
-                        description: EC2 Launch Template version number. While the
-                          API accepts values like $Default and $Latest, the API will
-                          convert the value to the associated version number (e.g.,
-                          1). Using the default_version or latest_version attribute
-                          of the aws_launch_template resource or data source is recommended
-                          for this argument.
+                        description: EC2 Launch Template version number.
                         type: string
                     type: object
                   nodeRoleArn:
@@ -2833,12 +2823,7 @@ spec:
                           id.
                         type: string
                       version:
-                        description: EC2 Launch Template version number. While the
-                          API accepts values like $Default and $Latest, the API will
-                          convert the value to the associated version number (e.g.,
-                          1). Using the default_version or latest_version attribute
-                          of the aws_launch_template resource or data source is recommended
-                          for this argument.
+                        description: EC2 Launch Template version number.
                         type: string
                     type: object
                   nodeRoleArn: