Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace references to upbound/uptest reusable workflows to upbound/official-providers-ci #6

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

jbw976
Copy link
Member

@jbw976 jbw976 commented Jun 10, 2024

Description of your changes

This PR cherry-picks the commit from crossplane/upjet-provider-template#64 and applies it to this repository.

Please see the description of that PR for context/details of this. I encountered the below error when running the Tag workflow in https://github.com/crossplane-contrib/provider-okta/actions/runs/9453981739 and realized that PR crossplane/upjet-provider-template#64 should fix this for us 🙏

error parsing called workflow ".github/workflows/tag.yaml" -> "upbound/uptest/.github/workflows/provider-tag.yml@main"

For posterity, I ran the following commands to cherry-pick the commit from a different repo:

git remote add patch-origin https://github.com/crossplane/upjet-provider-template.git
git fetch --all
git checkout -b update-workflows upstream/main
git --git-dir=../../crossplane/upjet-provider-template/.git format-patch -k -1 979663be8dc10b1dbabed011a7009a1e994d8077 --stdout | git am -3 -k --ignore-whitespace

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

This will be tested within the github actions during the next v0.3.0 release, which we're trying to get out today 😇

…ficial-providers-ci

- We've renamed the upbound/uptest repository as upbound/official-providers-ci

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@jbw976
Copy link
Member Author

jbw976 commented Jun 10, 2024

@rjop-hccgt if you want to take a look at this one so I can keep making progress on the v0.3.0 release 🙏

@jbw976 jbw976 requested a review from rjop-hccgt June 10, 2024 20:26
Copy link
Collaborator

@rjop-hccgt rjop-hccgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jbw976 jbw976 merged commit 5ea000f into crossplane-contrib:main Jun 10, 2024
8 checks passed
Copy link

Successfully created backport PR #7 for release-0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants