Update crossplane runtime latest #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalbury
force-pushed
the
update-crossplane-runtime-latest
branch
from
372691c
to
4a1e31b
Compare
…ne-tools Signed-off-by: Nick Albury <[email protected]> Signed-off-by: nalbury <[email protected]>
Signed-off-by: Nick Albury <[email protected]> Signed-off-by: nalbury <[email protected]>
Signed-off-by: Nick Albury <[email protected]> Signed-off-by: nalbury <[email protected]>
nalbury
force-pushed
the
update-crossplane-runtime-latest
branch
from
4a1e31b
to
5f68421
Compare
|
Apologies for the force push, had to sign my commits. |
turkenh
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Went to import the APIs here as a pkg in another internal controller we've been developing and I ran into some compatibility issues with
crossplane-runtimein other provider APIs (e.g. upbound AWS). This PR:crossplane-toolsandcrossplane-runtimeto current latest versionscontroller-runtimeand othercrossplane-runtimedependencies to latestmake generatecrossplane-runtimeandcontroller-runtimeupdatesI have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I've tested this locally by:
.github/workflows/ci.ymlrunningmake testmake test