Bump dependencies #122
Merged
Bump dependencies #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goober
force-pushed
the
feature/upgrade-dependencies
branch
from
26b05eb to
b422859
Compare
|
@goober I guess this needs to be bumped to |
goober
force-pushed
the
feature/upgrade-dependencies
branch
from
b422859 to
f7637e6
Compare
Bump golang to 1.17, golangci-lint to 1.43.0, helm to 3.8.0 Fixes linting issues after upgrading golangci-lint Signed-off-by: Mathias Åhsberg <[email protected]>
goober
force-pushed
the
feature/upgrade-dependencies
branch
from
f7637e6 to
f195dd4
Compare
|
At last it seems that the build goes through on my fork. |
turkenh
approved these changes
Mar 1, 2022
|
Thanks a lot @goober for dealing with all the weird issues so far, great work 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Bump golang to v 1.17 and some other dependencies to prepare for #121
I decided to split the two pull requests to make it easier to troubleshoot and review.
The golangci-lint version needed to be bumped as well, which lead to some new linting issues that are also fixed in this PR
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested