fix ready condition not being set to true #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-honeybadger
commented
Feb 6, 2024
| @@ -448,6 +448,10 @@ func (c *external) handleLastApplied(ctx context.Context, lastParameters *v1alph | |||
| isLastSyncOK := (desired.GetCondition(xpv1.TypeSynced).Status == v1.ConditionTrue) | |||
|
|
|||
| if isUpToDate && isLastSyncOK { | |||
| desired.SetConditions(xpv1.Available()) | |||
There was a problem hiding this comment.
When setting Ready condition right after a successful run, various transient errors can happen preventing this status update, and, potentially, leaving the condition False forever. This ensures Ready is set even if such errors occur
Signed-off-by: Dasha Komsa <[email protected]>
d-honeybadger
force-pushed
the
fix-ready-condition
branch
from
9f625cc to
b378660
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Follow-up for #294:
When the managed resource is modified in-place, turns out sometimes Crossplane applies these changes at the end of
Observeand sometimes it doesn't. During the initial PR testing, I must've had local debugging changes to the vendored crossplane-runtime packages that messed up with this behavior and made it so that managed resource changes were always applied.In this PR, status condition changes are persisted explicitly.
Fix Ready condition not getting set when its status is True
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Same as #294