Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set Ready for resources that miss status.conditions #32

Closed
wants to merge 1 commit into from

Conversation

tomaszkiewicz
Copy link

Description of your changes

Fixes #29

I have:

Copy link

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A resource could just have no conditions set yet afaict, so this could mean we mark as ready something that isn't actually ready

@tomaszkiewicz
Copy link
Author

Do you have any suggestions on how to handle cases like ProviderConfigs or EnvironmentConfigs which don't set conditions at all?

Ofz we can create a list of these resources, but it's not that flexible and required configuration by the user or (worse) in the code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Never Ready When Creating Env Config
2 participants