Skip to content

Commit

Permalink
Merge #1139
Browse files Browse the repository at this point in the history
1139: CI: Fix changelog check r=Alexhuszagh a=guihkx

`readarray` is supposed to be used with actual files, so replace it with `read` and also configure bash's internal field separator (IFS) to use the `;` character as the delimiter.

This allows for the list of files to be properly split.

Co-authored-by: guihkx <[email protected]>
  • Loading branch information
bors[bot] and guihkx authored Nov 16, 2022
2 parents ace4223 + 937cd0e commit 6635e20
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ jobs:
run: |
set -x
set -e
readarray -d ';' -t added_modified <<< '${{ steps.files.outputs.all_changed_files }}'
readarray -d ';' -t removed <<< '${{ steps.files.outputs.deleted_files }}'
IFS=';' read -a added_modified <<< '${{ steps.files.outputs.all_changed_files }}'
IFS=';' read -a removed <<< '${{ steps.files.outputs.deleted_files }}'
added_count=${#added_modified[@]}
removed_count=${#removed[@]}
if ${{ !contains(github.event.pull_request.labels.*.name, 'no changelog' ) }}; then
Expand Down

0 comments on commit 6635e20

Please sign in to comment.