Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: print parsing errors even when comparator throws an exception #47

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: print parsing errors even when comparator throws an exception #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions src/Criteo.OpenApi.Comparator.Cli/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,21 +40,30 @@ public static int Main(string[] args)
return 1;
}

var differences = OpenApiComparator.Compare(
oldOpenApiSpecification, newOpenApiSpecification, out var parsingErrors, options.StrictMode);

if (parsingErrors.Any())
IEnumerable<ParsingError> parsingErrors = null;
try
{
Console.Error.WriteLine("Errors occurred while parsing the OpenAPI specifications:");
foreach (var error in parsingErrors)
var differences = OpenApiComparator.Compare(
oldOpenApiSpecification, newOpenApiSpecification, out parsingErrors, options.StrictMode);
DisplayOutput(differences, options.OutputFormat);
return 0;
}
catch (Exception e)
{
Console.Error.WriteLine($"An error occurred while comparing the OpenAPI specifications: {e}");
return 1;
}
finally
{
if (parsingErrors.Any())
{
Console.Error.WriteLine(error);
Console.Error.WriteLine("Errors occurred while parsing the OpenAPI specifications:");
foreach (var error in parsingErrors)
{
Console.Error.WriteLine(error);
}
}
}

DisplayOutput(differences, options.OutputFormat);

return 0;
}

private static bool TryReadFile(string path, out string fileContent)
Expand Down
Loading