Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump AdMob version to v23.3.0 #312

Merged
merged 1 commit into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Next Version

# Version 7.1.0
- Bump AdMob to v23.3.0

# Version 7.0.0
- Add inventoryGroupId parameter

Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/java/AndroidModule.kt
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ private fun Project.defaultAndroidModule() {
compileSdkVersion(34)

defaultConfig {
minSdkVersion(19)
minSdkVersion(21)
targetSdkVersion(34)
versionCode = 1
versionName = sdkVersion()
Expand Down
14 changes: 7 additions & 7 deletions buildSrc/src/main/java/Deps.kt
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ object Deps {
}

object Test {
const val Core = "androidx.test:core:1.4.0"
const val Monitor = "androidx.test:monitor:1.5.0"
const val Runner = "androidx.test:runner:1.3.0"
const val Rules = "androidx.test:rules:1.3.0"
const val Core = "androidx.test:core:1.5.0"
const val Monitor = "androidx.test:monitor:1.6.1"
const val Runner = "androidx.test:runner:1.5.2"
const val Rules = "androidx.test:rules:1.5.0"
}
}

Expand Down Expand Up @@ -77,7 +77,7 @@ object Deps {
}

object Google {
const val AdMob = "com.google.android.gms:play-services-ads:22.1.0"
const val AdMob = "com.google.android.gms:play-services-ads:23.3.0"
const val AdMob19 = "com.google.android.gms:play-services-ads:19.0.1"
const val AdsIdentifier = "com.google.android.gms:play-services-ads-identifier:18.0.1"
}
Expand Down Expand Up @@ -108,7 +108,7 @@ object Deps {
}

object Kotlin {
private const val version = "1.5.31"
private const val version = "1.7.21"

const val GradlePlugin = "org.jetbrains.kotlin:kotlin-gradle-plugin:$version"
const val AllOpenPlugin = "org.jetbrains.kotlin:kotlin-allopen:$version"
Expand Down Expand Up @@ -152,7 +152,7 @@ object Deps {
}

object Moshi {
private const val version = "1.12.0"
private const val version = "1.14.0"

const val Kapt = "com.squareup.moshi:moshi-kotlin-codegen:$version"
const val Adapter = "com.squareup.moshi:moshi-adapters:$version"
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/java/SdkVersion.kt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import org.gradle.api.Project
import java.time.LocalDateTime
import java.time.format.DateTimeFormatter

private const val sdkBaseVersion = "7.0.0"
private const val sdkBaseVersion = "7.1.0"

private val timestamp = LocalDateTime.now().format(DateTimeFormatter.ofPattern("yyyyMMdd.HHmm"))

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ internal class CriteoInterstitialMraidController(
)
)
MraidState.DEFAULT -> close(onResult)
MraidState.EXPANDED -> onResult(MraidActionResult.Error("", CLOSE_ACTION))
MraidState.EXPANDED, MraidState.RESIZED ->
onResult(MraidActionResult.Error("", CLOSE_ACTION))
MraidState.HIDDEN -> onResult(
MraidActionResult.Error(
"Can't close from hidden state",
Expand Down
Loading