Feature/split compliance chart #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
big-andy-coates
previously approved these changes
Nov 15, 2023
There was a problem hiding this comment.
LGTM.
Thanks @harrel56, this is great.
If you have the time & inclination, I've added a few comments. Otherwise, just let me know and I'll merge your change and update afterwards.
descriptions and naming in general
LGTM.
layout
Also LGTM.
draft3 has only 1 supported implementation - should it still be displayed?
It's old, but why not. What would be nice is to put the newest drafts at the top, rather than at the bottom...
|
Sure, I'll be able to address your comments tomorrow - if it's more convenient for you can merge it right away too |
big-andy-coates
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #69
You can check how it looks on my gh pages: https://harrel56.github.io/json-schema-validation-comparison/functional
Things that I'm unsure about: