Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.1.4 to 5.2.1 #41

Merged
merged 3 commits into from
Oct 28, 2023
Merged

Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.1.4 to 5.2.1 #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b25a12
Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.1.4 to 5.2.1
dependabot[bot] Oct 21, 2023
7fe9f59
Merge branch 'main' into dependabot/gradle/com.github.spotbugs.snom-s…
big-andy-coates Oct 22, 2023
1b70d94
Fix new check failures
big-andy-coates Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buildSrc/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile>().configureEach
}

dependencies {
implementation("com.github.spotbugs.snom:spotbugs-gradle-plugin:5.1.4") // https://plugins.gradle.org/plugin/com.github.spotbugs
implementation("com.github.spotbugs.snom:spotbugs-gradle-plugin:5.2.1") // https://plugins.gradle.org/plugin/com.github.spotbugs
implementation("com.diffplug.spotless:spotless-plugin-gradle:6.22.0") // https://plugins.gradle.org/plugin/com.diffplug.spotless
implementation("gradle.plugin.org.kt3k.gradle.plugin:coveralls-gradle-plugin:2.12.2") // https://plugins.gradle.org/plugin/com.github.kt3k.coveralls
implementation("org.javamodularity:moduleplugin:1.8.12") // https://plugins.gradle.org/plugin/org.javamodularity.moduleplugin
Expand Down
6 changes: 6 additions & 0 deletions config/spotbugs/suppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,10 @@
<Source name="~.*[\\/]jmh_generated[\\/].*" />
</Match>

<Match>
<!-- Disable this check as it leads to longer names and harder to read code -->
<!-- Discussion: https://github.com/spotbugs/spotbugs/issues/2627 -->
<Bug pattern="PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_CLASS_NAMES"/>
</Match>

</FindBugsFilter>
6 changes: 6 additions & 0 deletions src/main/java/org/creekservice/kafka/test/perf/serde/ConfluentSerde.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,10 @@ public org.creekservice.kafka.test.perf.serde.Serializer serializer() {
public org.creekservice.kafka.test.perf.serde.Deserializer deserializer() {
return data -> deserializer.deserialize(TOPIC_NAME, data);
}

// Final, empty finalize method stops spotbugs CT_CONSTRUCTOR_THROW
// Can be moved to base type after https://github.com/spotbugs/spotbugs/issues/2665
@Override
@SuppressWarnings({"deprecation", "Finalize"})
protected final void finalize() {}
}
8 changes: 7 additions & 1 deletion src/main/java/org/creekservice/kafka/test/perf/serde/JustifySerde.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public class JustifySerde extends SerdeImpl {
private JsonValidationService service;
private JsonSchema schema;
private ProblemHandler handler;
public ObjectMapper mapper = JsonMapper.builder().build();
private ObjectMapper mapper = JsonMapper.builder().build();

public JustifySerde() {
service = JsonValidationService.newInstance();
Expand Down Expand Up @@ -160,4 +160,10 @@ private SpecVersion schemaVersion(final SchemaSpec spec) {
}
};
}

// Final, empty finalize method stops spotbugs CT_CONSTRUCTOR_THROW
// Can be moved to base type after https://github.com/spotbugs/spotbugs/issues/2665
@Override
@SuppressWarnings({"deprecation", "Finalize"})
protected final void finalize() {}
}
6 changes: 6 additions & 0 deletions src/main/java/org/creekservice/kafka/test/perf/serde/SchemaFriendSerde.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,4 +155,10 @@ private Schema parseSchema(
throw new RuntimeException(e);
}
}

// Final, empty finalize method stops spotbugs CT_CONSTRUCTOR_THROW
// Can be moved to base type after https://github.com/spotbugs/spotbugs/issues/2665
@Override
@SuppressWarnings({"deprecation", "Finalize"})
protected final void finalize() {}
}